Schamschi commented on issue #66: [NUMBERS-131] Re-write implementations of double approximation factory methods in BigFraction URL: https://github.com/apache/commons-numbers/pull/66#issuecomment-522159917 Hi Eric, sorry for the late reply, I have a bit much to do right now, and I don't think I'll be able to have a look at it before Sunday. But thanks for taking the time to look at it. There are some other things that need to be changed besides those you mentioned, for example the Javadoc, as I've learned in the meantime that MathJax is preferred over HTML also in private and package-private elements. And about the lengthy explanation of the algorithm: Do you have a specific suggestion? The essence of the algorithm is described in the Wikipedia article Continued Fraction, which is where I got it from, but I'm not sure if this is a suitable source to cite, because it doesn't contain any explanation as to why the algorithm works, and the references for the respective sections of the article were not very helpful either, as far as I remember. The book by A. Khinchin was the best source I could find, and the sections I cited are available on the free preview on Google Books, but I couldn't find a summary of the algorithm there (at least not in the free preview, I don't have the book, so I don't know if there is one somewhere in the rest of the book).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
