Stzx commented on a change in pull request #93: Control flow issues
URL: https://github.com/apache/commons-io/pull/93#discussion_r314936419
##########
File path: src/main/java/org/apache/commons/io/IOUtils.java
##########
@@ -778,11 +778,11 @@ public static boolean contentEqualsIgnoreEOL(final
Reader input1, final Reader i
String line1 = br1.readLine();
String line2 = br2.readLine();
- while (line1 != null && line2 != null && line1.equals(line2)) {
+ while (line1 != null && line1.equals(line2)) {
line1 = br1.readLine();
line2 = br2.readLine();
}
- return line1 == null ? line2 == null ? true : false :
line1.equals(line2);
+ return line1.equals(line2);
Review comment:
line1 may be null.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
