kinow commented on issue #434: Fixed a problem when parsing Chinese using the 
ToStringStyle.JSON_STYLE
URL: https://github.com/apache/commons-lang/pull/434#issuecomment-522926480
 
 
   I don't feel confident enough to vote +1 on this change. It seems to fix the 
bug described here, and the test is passing on Travis. But I am concerned about 
the change of removing the code that seems to escape the JSON value. It 
probably had a reason for being used I guess.
   
   But will take a better look later when I have more time to try the code and 
read code and commit history. Thanks for the pull request!
   
   Bruno

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to