kinow edited a comment on issue #49: Add support for EXIF 2.32
URL: https://github.com/apache/commons-imaging/pull/49#issuecomment-523195306
 
 
   @GITNE it's a checkstyle issue. If you click on "Details" next to the Travis 
CI check (👇 ) there should be a few jobs within this PR's build.
   
   Looking at a random job's log, I see:
   
   ```
   [ERROR] 
src/main/java/org/apache/commons/imaging/formats/tiff/constants/ExifTagConstants.java:[0]
 (misc) NewlineAtEndOfFile: File does not end with a newline.
   ```
   
   Looking at the changed files in this PR, it's possible to spot that your 
editor probably removed the [empty line at the end of the 
file](https://unix.stackexchange.com/a/18789/33951).
   
   
![image](https://user-images.githubusercontent.com/304786/63384547-324eb900-c3f3-11e9-9b1a-119cda9bdcd1.png)
   
   
   If you add that back, squash your commit, and push, Travis should kick again 
and hopefully pass this time 🤞 
   
   BTW, I've been holding back reviewing this one until you confirmed you got 
everything ready. I remember you mentioning you wanted to add something more... 
so just let us know once it's ready for review :)
   
   Cheers
   Bruno

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to