Stzx commented on a change in pull request #434: Fixed a problem when parsing
Chinese using the ToStringStyle.JSON_STYLE
URL: https://github.com/apache/commons-lang/pull/434#discussion_r317503278
##########
File path: src/main/java/org/apache/commons/lang3/builder/ToStringStyle.java
##########
@@ -2608,7 +2608,7 @@ private boolean isJsonObject(final String valueAsString)
{
* @param value the value to append.
*/
private void appendValueAsString(final StringBuffer buffer, final
String value) {
-
buffer.append('"').append(StringEscapeUtils.escapeJson(value)).append('"');
+ buffer.append('"').append(value).append('"');
Review comment:
Directly writing characters causes JSON special characters to not be
properly escaped.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
