[
https://issues.apache.org/jira/browse/LANG-1480?focusedWorklogId=301114&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-301114
]
ASF GitHub Bot logged work on LANG-1480:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/19 09:21
Start Date: 26/Aug/19 09:21
Worklog Time Spent: 10m
Work Description: verhas commented on pull request #446: LANG-1480
getAbbreviatedName refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#discussion_r317522502
##########
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##########
@@ -16,19 +16,11 @@
*/
package org.apache.commons.lang3;
+import org.apache.commons.lang3.mutable.MutableObject;
+
import java.lang.reflect.Method;
import java.lang.reflect.Modifier;
-import java.util.ArrayList;
-import java.util.Collections;
-import java.util.HashMap;
-import java.util.HashSet;
-import java.util.Iterator;
-import java.util.LinkedHashSet;
-import java.util.List;
-import java.util.Map;
-import java.util.Set;
-
-import org.apache.commons.lang3.mutable.MutableObject;
+import java.util.*;
Review comment:
This was the default IntelliJ setting to use * after more than 4 imports
from the same package.
I see no reason why not to use '*' in imports these days with such advanced
editors, but in case that is the project standard, I comply. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 301114)
Remaining Estimate: 22.5h (was: 22h 40m)
Time Spent: 1.5h (was: 1h 20m)
> ClassUtils. getAbbreviatedName(String ,int) returns too long result
> -------------------------------------------------------------------
>
> Key: LANG-1480
> URL: https://issues.apache.org/jira/browse/LANG-1480
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Affects Versions: 3.9
> Environment: Environment independent.
> Reporter: Peter Verhas
> Assignee: Bruno P. Kinoshita
> Priority: Major
> Original Estimate: 24h
> Time Spent: 1.5h
> Remaining Estimate: 22.5h
>
> In some cases, the algorithm decides incorrectly when to which package names
> to abbreviate. For example, abbreviating
> {{org.apache.commons.lang3.ClassUtils}} to the length 18 will result
> {{o.a.c.lang3.ClassUtils}} (22 characters) instead of {{o.a.c.l.ClassUtils}}
> (18 characters as requested). The reason for this is that the algorithm
> starts from the right and goes to the left abbreviating the packages and
> starts to abbreviate the packages when it runs out of the available space.
> Instead, the algorithm should start from the left and abbreviate all packages
> that would result in a too-long string without abbreviating the package name.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
