verhas commented on a change in pull request #446: LANG-1480 getAbbreviatedName
refactored to create appropriate length …
URL: https://github.com/apache/commons-lang/pull/446#discussion_r317534659
##########
File path: src/main/java/org/apache/commons/lang3/ClassUtils.java
##########
@@ -987,33 +1005,35 @@ public static boolean isAssignable(Class<?> cls, final
Class<?> toClass, final b
// Inner class
// ----------------------------------------------------------------------
+
/**
* <p>Is the specified class an inner class or static nested class.</p>
*
- * @param cls the class to check, may be null
+ * @param cls the class to check, may be null
* @return {@code true} if the class is an inner or static nested class,
- * false if not or {@code null}
+ * false if not or {@code null}
*/
public static boolean isInnerClass(final Class<?> cls) {
return cls != null && cls.getEnclosingClass() != null;
}
// Class loading
// ----------------------------------------------------------------------
+
/**
* Returns the class represented by {@code className} using the
* {@code classLoader}. This implementation supports the syntaxes
* "{@code java.util.Map.Entry[]}", "{@code java.util.Map$Entry[]}",
* "{@code [Ljava.util.Map.Entry;}", and "{@code [Ljava.util.Map$Entry;}".
*
- * @param classLoader the class loader to use to load the class
- * @param className the class name
+ * @param classLoader the class loader to use to load the class
+ * @param className the class name
* @param initialize whether the class must be initialized
* @return the class represented by {@code className} using the {@code
classLoader}
* @throws ClassNotFoundException if the class is not found
*/
public static Class<?> getClass(
- final ClassLoader classLoader, final String className, final
boolean initialize) throws ClassNotFoundException {
+ final ClassLoader classLoader, final String className, final boolean
initialize) throws ClassNotFoundException {
Review comment:
I am doing it. Actually, these formattings are clumsy in the original code,
and IntelliJ just reformatted automatically. I understand that it is no excuse
for creating a messy PR. Sorry.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
