[
https://issues.apache.org/jira/browse/LANG-1482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Verhas updated LANG-1482:
-------------------------------
Description:
The implementation of the methods {{asRunnable()}}, {{asConsumer()}},
{{asCallable()}}, {{asBiConsumer()}} etc. is redundant and copy-paste. They are
implemented with the structure (example from {{asRunnable()}}:
{code}
return () -> {
try {
pRunnable.run();
} catch (Throwable t) {
throw rethrow(t);
}
};
{code}
This try-catch structure is already implemented in the class and can be used
here simplifying the method to
{code}
return () -> run(pRunnable);
{code}
Also, the tests for {{asPredicate()}} and {{asBiPredicate()}} are missing.
was:
The implementation of the methods {{asRunnable()}}, {{asConsumer()}},
{{asCallable()}}, {{asBiConsumer()}} etc. is redundant and copy-paste. They are
implemented with the structure (example from {{asRunnable()}}:
{code}
return () -> {
try {
pRunnable.run();
} catch (Throwable t) {
throw rethrow(t);
}
};
{code}
This try-catch structure is already implemented in the class and can be used
here simplifying the method to
{code}
return () -> run(pRunnable);
{code}
Also, the tests for these methods are missing (except for the one
{{asRunnable()}).
> Functions
> ----------
>
> Key: LANG-1482
> URL: https://issues.apache.org/jira/browse/LANG-1482
> Project: Commons Lang
> Issue Type: Bug
> Components: lang.*
> Reporter: Peter Verhas
> Priority: Minor
> Fix For: 3.10
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> The implementation of the methods {{asRunnable()}}, {{asConsumer()}},
> {{asCallable()}}, {{asBiConsumer()}} etc. is redundant and copy-paste. They
> are implemented with the structure (example from {{asRunnable()}}:
> {code}
> return () -> {
> try {
> pRunnable.run();
> } catch (Throwable t) {
> throw rethrow(t);
> }
> };
> {code}
> This try-catch structure is already implemented in the class and can be used
> here simplifying the method to
> {code}
> return () -> run(pRunnable);
> {code}
> Also, the tests for {{asPredicate()}} and {{asBiPredicate()}} are missing.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
