verhas commented on a change in pull request #448: Lang 1482
URL: https://github.com/apache/commons-lang/pull/448#discussion_r317708414
##########
File path: src/main/java/org/apache/commons/lang3/Functions.java
##########
@@ -549,10 +584,26 @@ public static RuntimeException rethrow(Throwable
pThrowable) {
} else if (pThrowable instanceof Error) {
throw (Error) pThrowable;
} else if (pThrowable instanceof IOException) {
- throw new UncheckedIOException((IOException) pThrowable);
+ throw popStackTrace(new UncheckedIOException((IOException)
pThrowable));
} else {
- throw new UndeclaredThrowableException(pThrowable);
+ throw popStackTrace(new
UndeclaredThrowableException(pThrowable));
}
}
}
+
Review comment:
this may even could be a public utility method in some other class
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
