ecki commented on issue #69: VFS-727: Replaced VFS.getManager() calls to more 
local FileSystemManager access.
URL: https://github.com/apache/commons-vfs/pull/69#issuecomment-524970494
 
 
   I agree that we should not use the static getManager method at all, and it 
is probably best to deal with the failed tests in a separate change (i would 
suggest the test constructs a manner and hands it over and we change the teste 
function to check for null and fallback to getManager in worst case.
   
   BTW, i also have a Change which does require less of that scheme prefix 
checking, maybe all of that can be removed as well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to