garydgregory commented on a change in pull request #33: Add missing Java 9 and
Java 11 class file attributes.
URL: https://github.com/apache/commons-bcel/pull/33#discussion_r317837449
##########
File path: src/main/java/org/apache/bcel/classfile/Visitor.java
##########
@@ -131,6 +131,11 @@
*/
void visitMethodParameters(MethodParameters obj);
+ /**
+ * @since 6.0
+ */
+ void visitMethodParameter(MethodParameter obj);
Review comment:
New methods in interfaces must be added as Java 8 default methods in order
for us to maintain binary compatibility. Also the @since should be for 6.4.0,
not 6.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
