aremily commented on issue #94: CRYPTO-137: Fix compilation + support OpenSSL 1.1 on Windows. URL: https://github.com/apache/commons-crypto/pull/94#issuecomment-525529886 I saw that, too. I don't believe that I introduced that behavior. I can't be certain, but I think this is an open issue: https://issues.apache.org/jira/browse/CRYPTO-133 I took pains not to materially modify the locking code during my refactoring. I'll have another look at it if you disagree, but at this point I'd just recommend synchronizing the calling method. Thoughts? On Tue, Aug 27, 2019 at 1:31 PM Marcelo Vanzin <[email protected]> wrote: > Thanks for sharing the console output. That helps a lot. > > It also shows that OpenSslCryptoRandomTest.testRandomBytesMultiThreaded > is actually failing on Windows with OpenSSL 1.0, even though the build is > "passing". The error checking in that test is wrong (exceptions show up in > the output but they don't fail the test). > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/commons-crypto/pull/94?email_source=notifications&email_token=ABUDY7RWUSGVJRFFEK2JBETQGVQGRA5CNFSM4HFCEMAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5IQQEI#issuecomment-525404177>, > or mute the thread > <https://github.com/notifications/unsubscribe-auth/ABUDY7TKA32N4GUISSXWVEDQGVQGRANCNFSM4HFCEMAA> > . >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
