garydgregory commented on a change in pull request #32: Update signature 
scanning in Utility to support TypeParameters.
URL: https://github.com/apache/commons-bcel/pull/32#discussion_r319600486
 
 

 ##########
 File path: src/main/java/org/apache/bcel/classfile/Utility.java
 ##########
 @@ -464,6 +465,21 @@ public static String compactClassName( final String str ) 
{
     }
 
 
+    /**
+     * Shorten long class names, <em>java/lang/String</em> becomes
+     * <em>java.lang.String</em>,
+     * e.g.. If <em>chopit</em> is <em>true</em> the prefix <em>java.lang</em>
+     * is also removed.
+     *
+     * @param str The long class name
+     * @param chopit flag that determines whether chopping is executed or not
+     * @return Compacted class name
 
 Review comment:
   Hm, it looks like you just moved it, right? No API changes?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to