garydgregory commented on a change in pull request #450: Add and use
IllegalArgumentExceptions
URL: https://github.com/apache/commons-lang/pull/450#discussion_r321343698
##########
File path: src/main/java/org/apache/commons/lang3/Validate.java
##########
@@ -106,7 +108,7 @@ public Validate() {
*/
public static void isTrue(final boolean expression, final String message,
final long value) {
if (!expression) {
- throw new IllegalArgumentException(String.format(message,
Long.valueOf(value)));
+ throw IllegalArgumentExceptions.format(message,
Long.valueOf(value));
Review comment:
For this call site, I am 50/50, I implemented here for consistency. Picking
this call site to question the existence of the whole PR does not take into
account more complex use cases, IMO ;-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
