[
https://issues.apache.org/jira/browse/LANG-1485?focusedWorklogId=307310&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307310
]
ASF GitHub Bot logged work on LANG-1485:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/19 16:45
Start Date: 05/Sep/19 16:45
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #451: LANG-1485
: Add getters for lhs and rhs objects in DiffResult
URL: https://github.com/apache/commons-lang/pull/451#discussion_r321369998
##########
File path: src/main/java/org/apache/commons/lang3/builder/DiffResult.java
##########
@@ -88,6 +88,24 @@
}
}
+ /**
+ * <p>Gets the object the right object has been compared to.</p>
+ * @since 3.10
+ * @return the left object of the diff
+ */
+ public Object getLeft() {
+ return this.lhs;
+ }
+
+ /**
+ * <p>Gets the object the left object has been compared to.</p>
+ * @ 3.10
Review comment:
Nope :-( Use `@since` not `@`. Also, `@since` should be the _last_ tag.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 307310)
Time Spent: 2h 40m (was: 2.5h)
> DiffResult should expose its Left & Right objects with getters
> --------------------------------------------------------------
>
> Key: LANG-1485
> URL: https://issues.apache.org/jira/browse/LANG-1485
> Project: Commons Lang
> Issue Type: Wish
> Components: lang.builder.*
> Affects Versions: 3.9
> Reporter: Nicolas BARTHE-DEJEAN
> Priority: Trivial
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> Using a `DiffResult` object outside of any `Diffable` interface, I should be
> able to access the two objects of the diff.
> Currently, this is impossible since the two fields `Object lhs` and `Object
> rhs` are private and the class doesn't provide any getter to return them.
>
> PR on Github : https://github.com/apache/commons-lang/pull/451
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
