garydgregory commented on a change in pull request #459: (doc): Document public
RandomStringUtils exploit
URL: https://github.com/apache/commons-lang/pull/459#discussion_r324826590
##########
File path: src/main/java/org/apache/commons/lang3/RandomStringUtils.java
##########
@@ -34,7 +34,11 @@
* RandomStringGenerator</a> instead.</p>
*
* <p>Caveat: Instances of {@link Random}, upon which the implementation of
this
- * class relies, are not cryptographically secure.</p>
+ * class relies, are <b>not cryptographically secure</b>.
+ * Do not use this classes' default implementation of {@link Random} in
security sensitive locations,
+ * for example password reset key generation, as all future values can be
computed as proven by
+ * <a
href="https://medium.com/@alex91ar/the-java-soothsayer-a-practical-application-for-insecure-randomness-c67b0cd148cd";>
Review comment:
I say we KISS it and put in the comment without a link.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
