[ 
https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16932844#comment-16932844
 ] 

Gilles commented on GEOMETRY-32:
--------------------------------

bq. This is not just a matter of intuition, but also of the properties of the 
region. The points that are in the interior of the region must remain in the 
interior when everything is transformed.

Really?  This is actually a question: I don't know why it is a requirement (nor 
where it is defined). :-)
Pending your answer, I could imagine that in the same way that a reflection 
transforms "left" to "right", it could also transform "in" to "out".

bq. What do you mean here?

I'm not sure! ;-)
An interface to transform coordinates, and an interface to transform oriented 
shapes (?).
Maybe that does not make any sense, and I'm missing some basics about all of 
this (I couldn't find an opportunity to study the code, despite having some 
potential use-case...).


> BSPTree Updates
> ---------------
>
>                 Key: GEOMETRY-32
>                 URL: https://issues.apache.org/jira/browse/GEOMETRY-32
>             Project: Apache Commons Geometry
>          Issue Type: Improvement
>          Components: core
>            Reporter: Matt Juntunen
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> The following updates should be made to the BSPTree class:
> - add an {{isLeaf()}} method to replace all of the {{node.getCut() == null}} 
> expressions
> - add unit tests
> _Edit [2019-02-17]:_
> Additional goals:
> - Refactor the API to split the idea of a general BSPTree and a BSPTree used 
> for defining in/out regions. This could result in a BSPTree interface and a 
> RegionBSPTree interface. The goal here is to allow end-users to create their 
> own extensions of these classes and specialize them for their own 
> applications (for example, to implement spatial sorting or other algorithms). 
> This will be one of the only planned extension points in the library.
> - Make the API easier to use and extend and reduce the necessity of casting 
> (especially unchecked casting) as much as possible.
> - Add the idea of convex subhyperplanes to allow for more efficient tree 
> construction.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to