Stzx commented on a change in pull request #22: Adding capability to take max
upload size per request.Fileupload 1 3 1
URL: https://github.com/apache/commons-fileupload/pull/22#discussion_r326854509
##########
File path: src/main/java/org/apache/commons/fileupload/FileUploadBase.java
##########
@@ -206,6 +206,18 @@ public long getSizeMax() {
return sizeMax;
}
+ /**
+ * Gets allowed max size for current upload, subclasses can override this
method
+ * to calculate allowed size per request
+ * @param ctx requestContext - provides information related to current
upload request.
+ * @return max size allowed for current request
+ */
+ public long getSizeMaxForThisRequest(RequestContext ctx) {
+ return sizeMax;
Review comment:
What is the difference between this method implementation and the
`getSizeMax` method?
The `ctx` argument passed in is also not used.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
