Claudenw commented on issue #83: WIP: Initial bloom filter code contribution URL: https://github.com/apache/commons-collections/pull/83#issuecomment-535106644 If it makes it easier i can host a zoom session or we can do a discussion on slack. I should be home in 45 mi or so. On 17:30, Wed 25 Sep 2019 Claude Warren <[email protected] wrote: > The protobloomfilter should be immutable so the hash could be generated at > construction. Noyt in front of my computer at the moment. > > On 17:16, Wed 25 Sep 2019 Gary Gregory <[email protected] wrote: > >> @Claudenw <https://github.com/Claudenw> >> >> WRT >> org.apache.commons.collections4.bloomfilter.ProtoBloomFilter.hashCode() >> >> This looks like a recipe for concurrency bugs. It would be best to state >> the intent here: either make as much as possible immutable or document >> thread-safety expectations (if any.) >> >> — >> You are receiving this because you were mentioned. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/commons-collections/pull/83?email_source=notifications&email_token=AASTVHUKYOF4PFZIF7VYTB3QLOFGXA5CNFSM4IWGTGA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7SPKJQ#issuecomment-535098662>, >> or mute the thread >> <https://github.com/notifications/unsubscribe-auth/AASTVHUSM2SHGADXJL75NPDQLOFGXANCNFSM4IWGTGAQ> >> . >> >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
