[jira] [Work logged] (TEXT-172) escapeHtml3, escapeHtml4 unable to encode apostrophe character

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/TEXT-172?focusedWorklogId=319961&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319961
 ]

ASF GitHub Bot logged work on TEXT-172:
---------------------------------------

                Author: ASF GitHub Bot
            Created on: 28/Sep/19 06:04
            Start Date: 28/Sep/19 06:04
    Worklog Time Spent: 10m 
      Work Description: govi20 commented on pull request #122: TEXT-172: 
Failing test case to escape apastrophe
URL: https://github.com/apache/commons-text/pull/122#discussion_r329298267
 
 

 ##########
 File path: src/test/java/org/apache/commons/text/StringEscapeUtilsTest.java
 ##########
 @@ -319,6 +319,12 @@ public void testUnescapeHtml4() {
         assertEquals("Hello&##;World", 
StringEscapeUtils.unescapeHtml4("Hello&##;World"));
     }
 
+    @Test
+    public void testEscapeHtml4Apostrophe() {
+        String unescapedChar = StringEscapeUtils.unescapeHtml4 ("'");
+        assertEquals ("'",unescapedChar, StringEscapeUtils.escapeHtml4 
(unescapedChar));
 
 Review comment:
   Yeah, it failed in the Travis build.
   org.opentest4j.AssertionFailedError: ' ==> expected: <`&#39;`> but was: <'>
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 319961)
    Time Spent: 1h  (was: 50m)

> escapeHtml3, escapeHtml4 unable to encode apostrophe character
> --------------------------------------------------------------
>
>                 Key: TEXT-172
>                 URL: https://issues.apache.org/jira/browse/TEXT-172
>             Project: Commons Text
>          Issue Type: Bug
>    Affects Versions: 1.6, 1.8
>            Reporter: Govinda
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> I tried unescaping the below character, but seems it is not working.
>  
> {code:java}
> System.out.println(StringEscapeUtils.unescapeHtml3 ("&#39;"));
> System.out.println(StringEscapeUtils.escapeHtml3 ("&#39;"));
> System.out.println (StringEscapeUtils.escapeHtml3 
> (StringEscapeUtils.unescapeHtml3 ("&#39;")));
>  
> System.out.println (StringEscapeUtils.escapeHtml4 
> (StringEscapeUtils.unescapeHtml4 ("&#39;"))); 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)