verhas commented on a change in pull request #462: General Code Cleanup
URL: https://github.com/apache/commons-lang/pull/462#discussion_r329316547
##########
File path: src/test/java/org/apache/commons/lang3/RandomUtilsTest.java
##########
@@ -40,7 +39,7 @@
@Test
public void testConstructor() {
- assertNotNull(new RandomUtils());
Review comment:
That was absolutely clear, but I was picking up the thread when I checked
why the test instantiates the class at all and then I could see that
1.) there was no reason
2.) the constructors were calling super() which is done by default
3.) the constructors were the default constructors that do not need to be
written
4.) some tests just tested that the class with only the default constructor
exists in a different way
so I deleted the constructors, where they are created anyway and I changed
the tests to follow the same pattern.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
