[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945857#comment-16945857
]
Gilles Sadowski commented on COLLECTIONS-728:
---------------------------------------------
bq. other implementations of BloomFilter.
Would those reuse none of the current implementation ("StandardBloomFilter")?
Is "BloomFilter" an abstract _concept_ or is it tied to a reference
implementation?
IOW, would all the expected contributions be a subclass (with overridden
methods)? E.g. if a "BloomFilter" always comes with a notion of "getLog", then
a _protected_ "getApproximateLog" would allow customizing it.
You should really post (one post per such issue) to the "dev" ML to collect
more opinions on whether an _interface_ is the preferred approach (based on the
answers to the above questions).
bq. build() methods: They are not "necessary".
My point. ;-)
Ditto: preferences should be asked on the "dev" ML.
IMHO, the only (?) advantage (saving 2 keystrokes) is not worth almost doubling
that class' API.
bq. BloomCollection is not just an example.
OK.
Still, it is not clear to me whether it's worth creating a "collection"
subpackage (again, a question for the "dev" ML). Can the classes in that
package be used independently of {{BloomCollection}}? E.g. just by their name
* BloomCollectionConfiguration
* BloomCollectionStatistics
it seems that the above classes could (?) be static nested classes.
Also I suspect there is a relationship with the "interface" issue: In
{{BloomCollectionConfiguration}} has a {{gate}} initialized with a
{{StandardBloomFilter}} instance; thus, this higher-level utility assumes more
than the {{BloomFilter}} API. At first sight, this doesn't look right...
> BloomFilter contribution
> ------------------------
>
> Key: COLLECTIONS-728
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-728
> Project: Commons Collections
> Issue Type: Task
> Reporter: Claude Warren
> Priority: Minor
>
> Contribution of BloomFilter library comprising base implementation and gated
> collections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
