[
https://issues.apache.org/jira/browse/CSV-247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16945989#comment-16945989
]
Alex Herbert commented on CSV-247:
----------------------------------
[~ggregory]
I've updated the PR with a quick rebase. The code logic in CSVParser was
unchanged. The recent switch from JUnit 4 to 5 was preventing an auto-merge by
git but the change was trivial.
I also added a variant of the above test to the issues test: JiraCsv247Test.
> A single empty header is allowed when not allowing empty column headers.
> ------------------------------------------------------------------------
>
> Key: CSV-247
> URL: https://issues.apache.org/jira/browse/CSV-247
> Project: Commons CSV
> Issue Type: Bug
> Affects Versions: 1.7
> Reporter: Alex Herbert
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> If the settings are not allowing empty columns headers you can currently use
> a single empty header. This is because column headers are only checked for
> empty when they are duplicates. So it is the second empty header (the first
> duplicate) that raises an error. This test should pass but does not:
> {code:java}
> @Test(expected = IllegalArgumentException.class)
> public void testHeadersMissingOneColumnException() throws Exception {
> final Reader in = new StringReader("a,,c,d\n1,2,3,4\nx,y,z,zz");
> CSVFormat.DEFAULT.withHeader().parse(in).iterator();
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
