verhas commented on issue #461: Lang 1491 URL: https://github.com/apache/commons-lang/pull/461#issuecomment-539189787 I am sorry. I had a discussion with my son, and he read this thread and gave me feedback, that I accepted. I also edited my past comments to remove the parts that I see now, were offending. I did that as a gesture and not to hide the traces of my bad communication. The original versions are there, visible and also included as a quote in replies word by word, which is OK. My son told me that the original misunderstanding was that I communicated the aim of the change ambiguous. Because of that ambiguity, Mr. Kinoshita was asking me about the reference where JUnit requires that the tests are not public. There is no such thing. JUnit allows the tests to be public. They just do not demand the tests to be public anymore as we change from JUnit 4 to JUnit 5. This misunderstanding is my fault. I can also see that my response to this was not-professional in the details I deleted. Having all said I still believe that this pull request and also the next one following this is valuable for the project helping to keep the code clean and up to date and the PR should not be neglected.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
