[
https://issues.apache.org/jira/browse/BCEL-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949717#comment-16949717
]
Gary D. Gregory commented on BCEL-330:
--------------------------------------
I merged the PR but I now realize that this breaks binary compatibility:
{noformat}
[ERROR] Failed to execute goal
com.github.siom79.japicmp:japicmp-maven-plugin:0.14.1:cmp (default-cli) on
project bcel: There is at least one incompatibility:
org.apache.bcel.Constants[org.apache.bcel.Constants]:INTERFACE_REMOVED,org.apache.bcel.Constants[org.apache.bcel.Constants]:INTERFACE_REMOVED,org.apache.bcel.generic.MethodGen.addAnnotationsAsAttribute(org.apache.bcel.generic.ConstantPoolGen):METHOD_RETURN_TYPE_CHANGED,org.apache.bcel.generic.MethodGen.addParameterAnnotationsAsAttribute(org.apache.bcel.generic.ConstantPoolGen):METHOD_RETURN_TYPE_CHANGED,org.apache.bcel.Constants[org.apache.bcel.Constants]:INTERFACE_REMOVED,org.apache.bcel.Constants[org.apache.bcel.Constants]:INTERFACE_REMOVED,org.apache.bcel.Constants[org.apache.bcel.Constants]:INTERFACE_REMOVED
-> [Help 1]
{noformat}
We should therefore consider whether or not this change is really worth it,
even if the use case of casting a {{CodeException}} to a {{Constant}} is quite
unlikely but possible. But what is NOT unlikely is that someone writing code
like {{short aaLoad = LocalVariable.AALOAD}}. Therefore, I will revert and add
tests that establish the dependency.
> Remove unnecessary references to Constants
> ------------------------------------------
>
> Key: BCEL-330
> URL: https://issues.apache.org/jira/browse/BCEL-330
> Project: Commons BCEL
> Issue Type: Improvement
> Reporter: Mark Roberts
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When we changed from Constants.java to Const.java some references to
> Constants were left in. This causes Constants.class to be loaded
> unnecessarily.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
