garydgregory commented on a change in pull request #36: Made some variable
names more consistent with the other parts.
URL: https://github.com/apache/commons-bcel/pull/36#discussion_r336987489
##########
File path: src/main/java/org/apache/bcel/verifier/structurals/Subroutines.java
##########
@@ -121,16 +121,16 @@ public String toString() {
ret.append("', Instructions: '").append(instructions).append("'.");
ret.append(" Accessed local variable slots: '");
- int[] alv = getAccessedLocalsIndices();
- for (final int element : alv) {
- ret.append(element);ret.append(" ");
+ int[] lvs = getAccessedLocalsIndices();
+ for (final int lv : lvs) {
Review comment:
I do not see how trading an acronym for a mysterious TLA helps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services