garydgregory commented on a change in pull request #82: Made some variable
names more consistent with the other parts.
URL: https://github.com/apache/commons-compress/pull/82#discussion_r337001063
##########
File path:
src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java
##########
@@ -103,12 +103,12 @@ private void reAlignReading() throws IOException {
@Override
protected int addEntry(final int previousCode, final byte character)
throws IOException {
final int maxTableSize = 1 << getCodeSize();
- final int r = addEntry(previousCode, character, maxTableSize);
+ final int idx = addEntry(previousCode, character, maxTableSize);
if (getTableSize() == maxTableSize && getCodeSize() < maxCodeSize) {
reAlignReading();
incrementCodeSize();
}
- return r;
+ return idx;
Review comment:
I am -1 to abbreviated names like "idx". I prefer "index" or, as a fallback
for the brevity fans, the classic "i".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
