[
https://issues.apache.org/jira/browse/IMAGING-163?focusedWorklogId=334872&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-334872
]
ASF GitHub Bot logged work on IMAGING-163:
------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/19 10:07
Start Date: 28/Oct/19 10:07
Worklog Time Spent: 10m
Work Description: kinow commented on pull request #54: [IMAGING-163] Add
XmpEmbedabble interface to parsers that support it
URL: https://github.com/apache/commons-imaging/pull/54
An alternative propose to IMAGING-163. See #9 for another approach.
In this PR, a new interface `XmpEmbeddable` is added. The `getXmpXml` method
is removed from the `ImageParser`, and from any parser that was always
returning `null`.
Now, instead, only the parsers that currently support XMP metadata tags
implement that method. Not all parsers will implement this interface, as not
all image format specifications support XMP.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 334872)
Remaining Estimate: 0h
Time Spent: 10m
> DcxImageParser.getXmpXml() always returns null
> ----------------------------------------------
>
> Key: IMAGING-163
> URL: https://issues.apache.org/jira/browse/IMAGING-163
> Project: Commons Imaging
> Issue Type: Improvement
> Reporter: Michael Groß
> Priority: Major
> Labels: github
> Fix For: Review Patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Affects PCX format - can't spot this format in "Components" field.
> org.apache.commons.imaging.formats.dcx.DcxImageParser.getXmpXml() always
> returns null
> {noformat}
> /**
> * Extracts embedded XML metadata as XML string.
> * <p>
> *
> * @param byteSource
> * File containing image data.
> * @param params
> * Map of optional parameters, defined in ImagingConstants.
> * @return Xmp Xml as String, if present. Otherwise, returns null.
> * @throws org.apache.commons.imaging.ImageReadException
> * @throws java.io.IOException
> */
> @Override
> public String getXmpXml(final ByteSource byteSource, final
> ImagingParameters params)
> throws ImageReadException, IOException {
> return null;
> }
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
