[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16964893#comment-16964893
]
Claude Warren commented on COLLECTIONS-728:
-------------------------------------------
Quick note:
I somewhat get the rationale until here:
=== begin quote ===
True the Hasher could be limited to a StaticHasher and the Shape would not
be needed as the Static Hahser contains the Shape it was built with, but in the
general case a Hasher does not have a Shape.
Where it seems that the API could be improved so as to avoid having to pass
null when the "shape" argument is unused.
=== end quote ===
The API _always_ requires both arguments. For the static hasher the call would
look like `filter.merge( staticHasher.getShape(), staticHasher )`
I will comment on other bits later when I have more time.
> BloomFilter contribution
> ------------------------
>
> Key: COLLECTIONS-728
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-728
> Project: Commons Collections
> Issue Type: Task
> Reporter: Claude Warren
> Priority: Minor
> Attachments: BF_Func.md, BloomFilter.java, BloomFilterI2.java,
> Usage.md
>
>
> Contribution of BloomFilter library comprising base implementation and gated
> collections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
