[
https://issues.apache.org/jira/browse/NUMBERS-74?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Gilles Sadowski resolved NUMBERS-74.
------------------------------------
Resolution: Fixed
Commit 74a4d3353600d3099e15ba26257344d7c5296f87 ("master").
> Make "Fraction" a ValJO
> -----------------------
>
> Key: NUMBERS-74
> URL: https://issues.apache.org/jira/browse/NUMBERS-74
> Project: Commons Numbers
> Issue Type: Sub-task
> Components: fraction
> Reporter: Gilles Sadowski
> Priority: Major
> Labels: API
> Fix For: 1.0
>
>
> [This ML post|https://markmail.org/message/fhrnyg3nfer7y2cy] makes
> suggestions and points to potential issues with that class.
> A.o. things,
> * there seems to be some code overlap between the constructors and the
> {{getReducedFraction}} method (and the latter should probably be private
> anyways),
> * method {{percentageValue}} is not very useful,
> * a lot of constants should be removed,
> * {{serialVersionUID}} should be updated, and moved to the top of the
> declaration list.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
