bodewig commented on a change in pull request #83: COMPRESS-342 random access
of 7z files
URL: https://github.com/apache/commons-compress/pull/83#discussion_r341814563
##########
File path:
src/main/java/org/apache/commons/compress/archivers/sevenz/SevenZFile.java
##########
@@ -1208,6 +1208,42 @@ private InputStream getCurrentStream() throws
IOException {
return deferredBlockStreams.get(0);
}
+ public InputStream getInputStream(SevenZArchiveEntry entry) throws
IOException {
Review comment:
Please add javadoc for the new method. Probably stating it may perform bad.
Also I think it will break the current approach of accessing entries in
sequence as the "in sequence" code relies on the file position. Unless I'm
wrong we need a big warning here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
