kinow commented on a change in pull request #58: [IMAGING-243] PNG Writer
Indexed Color with semi-transparent Pixels and Better Compression
URL: https://github.com/apache/commons-imaging/pull/58#discussion_r348728912
##########
File path: src/main/java/org/apache/commons/imaging/formats/png/PngWriter.java
##########
@@ -596,8 +588,10 @@ public void writeImage(final BufferedImage src, final
OutputStream os, Map<Strin
// Debug.debug("uncompressed", uncompressed.length);
final ByteArrayOutputStream baos = new ByteArrayOutputStream();
- final DeflaterOutputStream dos = new DeflaterOutputStream(baos);
final int chunkSize = 256 * 1024;
+ Deflater deflater = new Deflater(Deflater.BEST_COMPRESSION);
Review comment:
I think it's not necessary. These values are already at the `Deflater`
class, and may change. So we should be better allowing users to pass anything.
There is also a ticket I think to allow for other compression algorithms (even
though specification uses only Deflater, it says vendors can use other
algorithms), in which case it could lead to having more values for each
algorithm.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
