markt-asf commented on a change in pull request #13: [DAEMON-414] prunsrv uses
its log is before it is initialized.
URL: https://github.com/apache/commons-daemon/pull/13#discussion_r348985086
##########
File path: src/native/windows/apps/prunsrv/prunsrv.c
##########
@@ -1758,9 +1763,6 @@ void __cdecl main(int argc, char **argv)
}
}
- apxLogOpen(gPool, SO_LOGPATH, SO_LOGPREFIX, SO_LOGROTATE);
- apxLogLevelSetW(NULL, SO_LOGLEVEL);
- apxLogWrite(APXLOG_MARK_DEBUG "Apache Commons Daemon procrun log
initialized.");
if (SO_LOGROTATE)
apxLogWrite(APXLOG_MARK_DEBUG "Log will rotate each %d seconds.",
SO_LOGROTATE);
Review comment:
I'd include these two lines in the code you move as well. It think it makes
sense to keep this message with the "log initialized message"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
