[
https://issues.apache.org/jira/browse/IMAGING-242?focusedWorklogId=348677&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-348677
]
ASF GitHub Bot logged work on IMAGING-242:
------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/19 07:36
Start Date: 24/Nov/19 07:36
Worklog Time Spent: 10m
Work Description: mureinik commented on pull request #61: IMAGING-242
Complete the migration to JUnit Jupiter
URL: https://github.com/apache/commons-imaging/pull/61
This PR follows up https://github.com/apache/commons-imaging/pull/59 and
completes the migration to JUnit Jupiter:
- Usages of `org.junit.Assert.assert[Not]Null` were replaced with
`org.junit.jupiter.api.Assertions.asserrt[Not]Null`.
- Usages of `@Theories` and `@DataPoints` where replaces with JUnit
Jupiter's `@ParameterizedTest` with `@MethodSources`. Unfortunately, Jupiter
doesn't have a built-in capability to create a Cartesian product of datapoints
like `@Theories` does, so this logic had to be explicitly implemented in
`RountripBase`.
- With this cleanup, the additional Junit 5 Vintage dependencies could be
removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 348677)
Time Spent: 40m (was: 0.5h)
> Move to JUnit 5
> ---------------
>
> Key: IMAGING-242
> URL: https://issues.apache.org/jira/browse/IMAGING-242
> Project: Commons Imaging
> Issue Type: Improvement
> Components: imaging.*
> Affects Versions: 1.0-alpha1
> Reporter: Bruno P. Kinoshita
> Assignee: Bruno P. Kinoshita
> Priority: Minor
> Fix For: 1.0-alpha2
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
