[
https://issues.apache.org/jira/browse/GEOMETRY-32?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16981171#comment-16981171
]
Matt Juntunen commented on GEOMETRY-32:
---------------------------------------
bq. Isn't it possible to increase the number of allowed parameters?
It is, but I think we still want the project as a whole to follow the current
max parameter number. Each exception to that rule should be called out
explicitly.
bq. Note: Javadoc for the linearCombination methods needs fixing
Good call. Fixed.
bq. we should definitely use MathJax
Sounds good. I've never used that before. I recommend that as another follow-up
issue.
bq. What about e.g. FieldVector3D?
Oh, yeah. I didn't go far enough back:-) None of the field-related classes made
it over in the initial creation of commons-geometry because it would have
required a dependency back to commons-math for the {{Field}} functionality.
> BSPTree Updates
> ---------------
>
> Key: GEOMETRY-32
> URL: https://issues.apache.org/jira/browse/GEOMETRY-32
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Components: core
> Reporter: Matt Juntunen
> Priority: Major
> Labels: pull-request-available
> Time Spent: 40m
> Remaining Estimate: 0h
>
> The following updates should be made to the BSPTree class:
> - add an {{isLeaf()}} method to replace all of the {{node.getCut() == null}}
> expressions
> - add unit tests
> _Edit [2019-02-17]:_
> Additional goals:
> - Refactor the API to split the idea of a general BSPTree and a BSPTree used
> for defining in/out regions. This could result in a BSPTree interface and a
> RegionBSPTree interface. The goal here is to allow end-users to create their
> own extensions of these classes and specialize them for their own
> applications (for example, to implement spatial sorting or other algorithms).
> This will be one of the only planned extension points in the library.
> - Make the API easier to use and extend and reduce the necessity of casting
> (especially unchecked casting) as much as possible.
> - Add the idea of convex subhyperplanes to allow for more efficient tree
> construction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
