[
https://issues.apache.org/jira/browse/COLLECTIONS-728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985222#comment-16985222
]
Claude Warren commented on COLLECTIONS-728:
-------------------------------------------
The usage.md was for you to understand the usage of bloom filters. I was not
intending to submit it. I will remove it from the submission.
as to the Dynamic.Factory, I have another hasher implementation
(CachingHasher) that I have not included here (as I am trying to keep this to a
minimum) but that Hasher also uses the factory model. CachingHasher has
different characteristics from the Dynamic hasher and thus different set of
acceptable hashing functions. I don't see a way to create a single
Hasher.Factory implementation that will handle both. I think it is best for
Dynamic.Factory to be a factory that returns DynamicHashers, and
CachingHahser.Factory to be a factory that returns CachingHashers. It is a
clear separation. Perhaps it makes sense to remove the Hasher DEFAULT from the
Hasher.Factory interface to avoid confusion.
I will raise the External dependency on the ML.
> BloomFilter contribution
> ------------------------
>
> Key: COLLECTIONS-728
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-728
> Project: Commons Collections
> Issue Type: Task
> Reporter: Claude Warren
> Priority: Minor
> Attachments: BF_Func.md, BloomFilter.java, BloomFilterI2.java,
> Usage.md
>
>
> Contribution of BloomFilter library comprising base implementation and gated
> collections.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
