[
https://issues.apache.org/jira/browse/COMPRESS-477?focusedWorklogId=351737&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-351737
]
ASF GitHub Bot logged work on COMPRESS-477:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/19 05:12
Start Date: 02/Dec/19 05:12
Worklog Time Spent: 10m
Work Description: bodewig commented on pull request #86: COMPRESS-477
building a split zip
URL: https://github.com/apache/commons-compress/pull/86#discussion_r352363968
##########
File path:
src/main/java/org/apache/commons/compress/compressors/FileNameUtil.java
##########
@@ -193,4 +193,19 @@ public String getCompressedFilename(final String
fileName) {
return fileName + defaultExtension;
}
+ public static String getBaseName(String filename) {
+ if (filename == null) {
+ return null;
+ }
+
+ int lastSeparatorPosition = Math.max(filename.lastIndexOf('/'),
filename.lastIndexOf('\\'));
+ String name = filename.substring(lastSeparatorPosition + 1);
Review comment:
`new File(filename).getName()` will give you the last segment of the path.
This is more robust than the `lastIndexOf` approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 351737)
Time Spent: 4h 50m (was: 4h 40m)
> Support for splitted zip files
> ------------------------------
>
> Key: COMPRESS-477
> URL: https://issues.apache.org/jira/browse/COMPRESS-477
> Project: Commons Compress
> Issue Type: New Feature
> Components: Archivers
> Affects Versions: 1.18
> Reporter: Luís Filipe Nassif
> Priority: Major
> Labels: zip
> Fix For: 1.20
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> It would be very useful to support splitted zip files. I've read
> [https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT] and understood
> that simply concatenating the segments and removing the split signature
> 0x08074b50 from first segment would be sufficient, but it is not that simple
> because compress fails with exception below:
> {code}
> Caused by: java.util.zip.ZipException: archive's ZIP64 end of central
> directory locator is corrupt.
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory64(ZipFile.java:924)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.positionAtCentralDirectory(ZipFile.java:901)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.populateFromCentralDirectory(ZipFile.java:621)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:295)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:280)
> ~[commons-compress-1.18.jar:1.18]
> at
> org.apache.commons.compress.archivers.zip.ZipFile.<init>(ZipFile.java:236)
> ~[commons-compress-1.18.jar:1.18]
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
