christoffer-rydberg commented on issue #62: Add disposal method to GIF metadata
URL: https://github.com/apache/commons-imaging/pull/62#issuecomment-561063850
 
 
   @kinow Any suggestions how to unit test this PR? Basically the only added 
logic is a private method to convert from internal gif int value to an enum. I 
could:
   A) Make it public (bad since it is only needed by the parser).
   B) Test it using reflection (not a fan)
   C) Test it indirectly by adding more test gifs with different disposal 
methods (need to find such gifs).
   D) Move the method to another class (e.g. MethodDisposalConverter) with a 
public testable method and inject it into the parser.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to