behrangsa commented on issue #31: Added non-blocking File digest methods
URL: https://github.com/apache/commons-codec/pull/31#issuecomment-561149352
 
 
   > Let's step back and ask: Why would we want two implementations for `File` 
objects? If NIO does the job better, then let's change the implementation to do 
that.
   
   I thought using NIO would improve performance but in my limited tests I 
didn't notice a meaningful difference. It would be great if some NIO experts 
could chime in.
   
   However we can:
   
   * Get rid of `nonblockingDigest(final MessageDigest messageDigest, final 
File data)`
   * Rename `nonblockingDigest(final MessageDigest messageDigest, final 
RandomAccessFile data)` to `digest(final MessageDigest messageDigest, final 
RandomAcessFile data)`
   
   as the first method calls wraps the File in a RandomAccessFile and passes it 
to the 2nd method anyway.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to