[
https://issues.apache.org/jira/browse/GEOMETRY-69?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16989736#comment-16989736
]
Gilles Sadowski commented on GEOMETRY-69:
-----------------------------------------
Givne that they are nested, could we abbreviate the names of the "enum" classes:
* VisitOrder -> Order
* VisitResult -> Result
?
I find it clearer to not
{code}
import
org.apache.commons.geometry.core.partitioning.bsp.BSPTreeVisitor.VisitOrder;
{code}
but rather
{code}
import org.apache.commons.geometry.core.partitioning.bsp.BSPTreeVisitor;
{code}
(and use the "qualified" name in code).
Could we abbreviate the method names, e.g.
* acceptVisitor -> accept
* ...
?
> BSPTreeVisitor stop visit
> -------------------------
>
> Key: GEOMETRY-69
> URL: https://issues.apache.org/jira/browse/GEOMETRY-69
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Update the BSPTreeVisitor interface to allow implementations to stop the node
> visit process when desired. The current implementation always visits all
> nodes in the tree. The JDK {{FileVisitor}} interface might be a good
> reference.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
