[
https://issues.apache.org/jira/browse/COLLECTIONS-737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17000321#comment-17000321
]
Pengyu Nie commented on COLLECTIONS-737:
----------------------------------------
Any update for this issue? I'm happy to follow up if there is any concern.
Thanks!
> The test FluentIterableTest.size should be split
> ------------------------------------------------
>
> Key: COLLECTIONS-737
> URL: https://issues.apache.org/jira/browse/COLLECTIONS-737
> Project: Commons Collections
> Issue Type: Test
> Components: Collection
> Reporter: Pengyu Nie
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> The first part of FluentIterableTest.size is not testing function
> FluentIterable.size (see code copied below). Actually,
> FluentIterable.size will not be invoked at all, because
> FluentIterable.of(null) will throw an NPE before that. This part
> should be extracted as a separate unit test like
> FluentIterableTest.ofNull.
> {code:java}
> try {
> FluentIterable.of((Iterable<?>) null).size();
> fail("expecting NullPointerException");
> } catch (final NullPointerException npe) {
> // expected
> }{code}
> I'll create a pull request for this issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)