garydgregory commented on issue #454: Make diff result extends pair URL: https://github.com/apache/commons-lang/pull/454#issuecomment-568216999 I created https://issues.apache.org/jira/browse/LANG-1503 to bring in the changes to the three Pair classes. Note that there are only new factory methods. The additional constructors are not needed. I think it is also better design to have the conversion work done in factory methods and the results funneled to the constructors. The DiffResult change of superclass is not brought in as it would break binary compatibility. You can check this by running: ``` mvn clean package site -V -P jacoco -P japicmp ``` and checking the generated report in the site at `target\site\index.html` where you will see: ``` MODIFIED (Serializable incompatible(!): superclass modified) public class org.apache.commons.lang3.builder.DiffResult ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
