[
https://issues.apache.org/jira/browse/VFS-590?focusedWorklogId=362613&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-362613
]
ASF GitHub Bot logged work on VFS-590:
--------------------------------------
Author: ASF GitHub Bot
Created on: 23/Dec/19 18:06
Start Date: 23/Dec/19 18:06
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #75: VFS-590
VFS-617 Proceed with moveTo operation if the exec channel for…
URL: https://github.com/apache/commons-vfs/pull/75
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 362613)
Time Spent: 20m (was: 10m)
> SFTP moveTo operation might fail on permission checks even if the operation
> itself might succeed
> ------------------------------------------------------------------------------------------------
>
> Key: VFS-590
> URL: https://issues.apache.org/jira/browse/VFS-590
> Project: Commons VFS
> Issue Type: Bug
> Affects Versions: Nightly Builds
> Reporter: L
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Continuing with SFTP moveTo, see VFS-588 and VFS-589 for more details.
> The permission checks that VFS performs during moveTo() can result in
> failure.
> org.apache.commons.vfs2.provider.AbstractFileObject.moveTo(final FileObject
> destFile) starts with some checks:
> {code:java}
> @Override
> public void moveTo(final FileObject destFile) throws FileSystemException
> {
> if (canRenameTo(destFile))
> {
> if (!getParent().isWriteable())
> {
> throw new
> FileSystemException("vfs.provider/rename-parent-read-only.error",
> getName(),
> getParent().getName());
> }
> }
> else
> {
> if (!isWriteable())
> {
> throw new
> FileSystemException("vfs.provider/rename-read-only.error", getName());
> }
> }
> {code}
> The problem is: isWriteable() might fail or even hang. Performing moveTo
> without this check might successfully rename the file.
> isWriteable() in case of SFTP can fail if the server disables SSH
> channelExec. Or if it does not support "id" command.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
