[
https://issues.apache.org/jira/browse/GEOMETRY-81?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEOMETRY-81:
-----------------------------------
Labels: pull-request-available (was: )
> Rename ConvexSubPlane to Facet
> ------------------------------
>
> Key: GEOMETRY-81
> URL: https://issues.apache.org/jira/browse/GEOMETRY-81
> Project: Apache Commons Geometry
> Issue Type: Improvement
> Reporter: Matt Juntunen
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.0
>
>
> The class name {{ConvexSubPlane}} is somewhat ungainly. The name {{Facet}}
> might be a better name for this class. This similar to how the convex
> subhyperplane class in 2D is named {{Segment}} and not "ConvexSubLine".
> Pros:
> - Shorter, more familiar name
> - More consistency with the naming conventions of convex subhyperplanes in
> other dimensions (eg, Segment, GreatArc)
> Cons:
> - The name "facet" does not necessarily imply that the shape is convex.
> However, this is the common usage.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
