[
https://issues.apache.org/jira/browse/TEXT-175?focusedWorklogId=368298&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-368298
]
ASF GitHub Bot logged work on TEXT-175:
---------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/20 17:35
Start Date: 08/Jan/20 17:35
Worklog Time Spent: 10m
Work Description: garydgregory commented on pull request #127: TEXT-175:
WordUtils.capitalizeFully should use all whitespaces if del…
URL: https://github.com/apache/commons-text/pull/127#discussion_r364354913
##########
File path: src/main/java/org/apache/commons/text/WordUtils.java
##########
@@ -51,6 +51,18 @@ public WordUtils() {
super();
}
+ /* All common whitespaces as defined in Character.isWhitespace(char) */
+ private static final char[] WHITESPACE_CHARS =
+ { '\t', '\n', '\u000B', '\f', '\r', '\u001C', '\u001D', '\u001E',
'\u001F', ' ' };
Review comment:
This seems like it will be a maintenance headache. Can the stock method
`Character.isWhitespace()` be used?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 368298)
Time Spent: 20m (was: 10m)
> WordUtils.capitalizeFully(String) only splits by spaces, instead of any
> whitespace
> ----------------------------------------------------------------------------------
>
> Key: TEXT-175
> URL: https://issues.apache.org/jira/browse/TEXT-175
> Project: Commons Text
> Issue Type: Bug
> Affects Versions: 1.2, 1.8
> Reporter: David Lavati
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {color:#172b4d}Due to the performance improvements in TEXT-98, this no longer
> works as originally designed:{color}
> *
> {color:#172b4d}{{org.apache.commons.text.WordUtils.capitalizeFully("a\tb\nc")}}{color}
> ** should return "A\t\B\nC", but returns "A\t\b\nc" instead
> * {color:#172b4d}{{org.apache.commons.text.WordUtils.capitalizeFully("a b
> c")}}{color}
> ** still works as "A B C"
>
> A possible option while keeping the improvements would be to create a static
> collection of whitespace codepoints and
> * either include that into the set, instead of just the single whitespace,
> as done at
> [https://github.com/apache/commons-text/commit/fb6d5935451397c561bd52cf1d483975f83b2c7b#diff-9222b0893e00b43fd6519d95e395f9b3R892]
> * or if that touches too many things, call {{capitalize(String,char[])}}
> inside capitalizeFully with these chars as delimiters by default.
>
> Tested in 1.8
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
