PeterAlfreadLee commented on issue #90: Compress-477 : add zip64 support for 
split zip
URL: https://github.com/apache/commons-compress/pull/90#issuecomment-573317729
 
 
   > When I was trying to extract the 70,000+ split segments using 
ZipSplitReadOnlySeekableByteChannel, I got an error : too many open files. I 
realized that the ZipSplitReadOnlySeekableByteChannel and 
MultiReadOnlySeekableByteChannel may open all the split segments before reading 
them - and I think this is meaningless and could be improved. I'm trying to 
improve them using a 'open files when needed' way. Therefore we don't need to 
open all the files before reading, which may use a lot of file handles of OS, 
and we can extract split zips that contain a lot of split segments.
   
   I have finished this and have tested it(even through it's pretty time 
consuming when there're a lot split segments).
   I'm not sure if this(open file when it's needed to be read) is needed. What 
do you think? @bodewig 
   If this is needed, I'm not sure if I should push another seprate PR when 
this PR is merged(as zip64 split is needed to test it), or I can just push the 
code in this PR?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to