brettlounsbury commented on a change in pull request #101: IO-649 - Improve the
performance of the contentEquals() methods.
URL: https://github.com/apache/commons-io/pull/101#discussion_r365997580
##########
File path: src/main/java/org/apache/commons/io/IOUtils.java
##########
@@ -708,31 +706,79 @@ public static void closeQuietly(final Writer output) {
@SuppressWarnings("resource")
public static boolean contentEquals(final InputStream input1, final
InputStream input2)
throws IOException {
+ return contentEquals(input1, input2, DEFAULT_BUFFER_SIZE);
+ }
+
+ /**
+ * Compares the contents of two Streams to determine if they are equal or
not.
+ * <p>
+ * This method buffers the input internally.
+ *
+ * @param input1 the first stream
+ * @param input2 the second stream
+ * @param bufferSize the size of the internal buffer to use.
+ * @return true if the content of the streams are equal or they both don't
+ * exist, false otherwise
+ * @throws NullPointerException if either input is null
Review comment:
I looked at the beginning of each method again. Both contentEquals methods
start with the following statements. This can never throw a
NullPointerException. If both streams are null they will be equal and
therefore always return true. If one stream is null and the other is not it
will always return false based on the XOR logic. Only if both streams are
non-null and not the same object will the actual logic of the method execute.
I pushed a new version without the `@throws NullPointerException` in the
javadoc.
```
if (input1 == input2) {
return true;
}
if (input1 == null ^ input2 == null) {
return false;
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
