[
https://issues.apache.org/jira/browse/CODEC-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17018547#comment-17018547
]
Andy Seaborne commented on CODEC-264:
-------------------------------------
Hi Alex,
I've visually inspected the code in git ([commit
f5a61f0c|https://github.com/apache/commons-codec/commit/f5a61f0c]) and it looks
correct.
Thanks / Andy
> murmur3.hash128() does not account for unsigned seed argument
> -------------------------------------------------------------
>
> Key: CODEC-264
> URL: https://issues.apache.org/jira/browse/CODEC-264
> Project: Commons Codec
> Issue Type: Bug
> Affects Versions: 1.13
> Reporter: Claude Warren
> Assignee: Alex Herbert
> Priority: Major
> Fix For: 1.14
>
> Attachments: YonikMurmur3Tests.java
>
>
> The original murmur3_x64_128 code used unsigned int for seed arguments.
> Using the equivalent bit patterns in the commons codec version does not yield
> the same results.
> I believe this is because the commons version does not account for sign
> extension etc.
> Yonic Seeley [~yonik] has explains the issue in his implementation
> https://github.com/yonik/java_util/blob/master/src/util/hash/MurmurHash3.java
> He provides a test case to show that his code returns the same answers as the
> original C/C++ code. I modified that test to call the codec version to show
> the error.
> I have attached that test case.
> Given that the original code is in the wild I am uncertain how to fix this
> issue.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
