kinow commented on issue #83: Initial bloom filter code contribution
URL: 
https://github.com/apache/commons-collections/pull/83#issuecomment-575937004
 
 
   BTW, almost forgot this one
   
   > Perhaps it would make sense to create a SimpleBloomFilter that merges the 
DynamicHasher and the BitSetBloomFilter and provides methods like the Hadoop 
Bloom filter.
   
   +1 I think that could be simpler, especially for users familiar with 
existing implementations ([Guava's 
BloomFilter](https://guava.dev/releases/22.0/api/docs/com/google/common/hash/BloomFilter.html#mightContain-T-)
 also has a `mightContain(T Object)` method, similar to how Python & Hadoop 
work)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to