kinow commented on a change in pull request #37: [IMAGING-248]: ICNS: missing element types; some safety checks URL: https://github.com/apache/commons-imaging/pull/37#discussion_r368319172
########## File path: src/main/java/org/apache/commons/imaging/formats/icns/IcnsDecoder.java ########## @@ -21,6 +21,7 @@ import java.util.List; import org.apache.commons.imaging.ImageReadException; +import org.apache.commons.imaging.Imaging; Review comment: This could lead to a circular dependency between the package `oac.imaging`, and the type `Imaging`, with this file. So I will try to use the parser directly instead 👍 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
